Bug 85111

Summary: PerfTestRunner.computeStatistics incorrectly calculates min, max and median
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Tom Zakrajsek <tomz>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, tomz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

WebKit Review Bot
Reported 2012-04-27 16:42:58 PDT
PerfTestRunner.computeStatistics incorrectly calculates min, max and median Requested by tomz on #webkit.
Attachments
Patch (1.35 KB, patch)
2012-04-27 16:49 PDT, Tom Zakrajsek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tom Zakrajsek
Comment 1 2012-04-27 16:44:40 PDT
The data.sort() in this routine is doing an alphabetic sort. The dataset [1 3 7 10] shows the problem.
Tom Zakrajsek
Comment 2 2012-04-27 16:49:34 PDT
Created attachment 139308 [details] Patch
Tom Zakrajsek
Comment 3 2012-04-27 16:55:16 PDT
I'm not sure where tests for this should go but we most *certainly* need them for the statistics package. I'll be happy to write some.
Ryosuke Niwa
Comment 4 2012-04-27 17:09:20 PDT
Unfortunately we don't have any tests for this, and that's why we have this bug. Maybe we can add something in LayoutTests/fast/harness/ that pulls this file?
Ryosuke Niwa
Comment 5 2012-04-27 17:11:51 PDT
Now it makes sense that some of min/max/stdev looked bogus. But this problem should go away once we start importing all values. Still nice to fix it here thouh.
Tom Zakrajsek
Comment 6 2012-04-27 23:30:42 PDT
In that case, could you r+ this and I'll get the tests in ASAP? I'd rather not hold off while we're continuing to generate incorrect data. I tested the fix manually.
Ryosuke Niwa
Comment 7 2012-04-28 02:26:42 PDT
Comment on attachment 139308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139308&action=review > PerformanceTests/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). This line should appear before the description.
Tom Zakrajsek
Comment 8 2012-04-29 11:21:29 PDT
Committed r115598: <http://trac.webkit.org/changeset/115598>
Note You need to log in before you can comment on or make changes to this bug.