Bug 85103

Summary: [Texmap] TextureMapperLayer uses intermediate surfaces too eagerly
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: New BugsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: jturcotte, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Noam Rosenthal
Reported 2012-04-27 15:32:25 PDT
[Texmap] TextureMapperLayer uses intermediate surfaces too eagerly
Attachments
Patch (4.80 KB, patch)
2012-04-27 15:39 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (4.27 KB, patch)
2012-04-29 12:04 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2012-04-27 15:39:09 PDT
Created attachment 139293 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-04-29 04:00:08 PDT
Comment on attachment 139293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139293&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:221 > + return MoreThanOneDescendantWithContent; MultipleDecendantsWithContent > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:231 > + count = 1; What is the idea with setting it to 1 here and continue iterating? wont you end inside the same if and return MoreThanOne? > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:254 > + bool mightHaveOverlaps = countDescendantsWithContent() == MoreThanOneDescendantWithContent; canOverlap?
Noam Rosenthal
Comment 3 2012-04-29 12:04:12 PDT
Created attachment 139404 [details] Patch
WebKit Review Bot
Comment 4 2012-04-30 07:07:26 PDT
Comment on attachment 139404 [details] Patch Clearing flags on attachment: 139404 Committed r115629: <http://trac.webkit.org/changeset/115629>
WebKit Review Bot
Comment 5 2012-04-30 07:07:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.