Bug 85103 - [Texmap] TextureMapperLayer uses intermediate surfaces too eagerly
Summary: [Texmap] TextureMapperLayer uses intermediate surfaces too eagerly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Noam Rosenthal
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-27 15:32 PDT by Noam Rosenthal
Modified: 2012-04-30 07:07 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.80 KB, patch)
2012-04-27 15:39 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (4.27 KB, patch)
2012-04-29 12:04 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-04-27 15:32:25 PDT
[Texmap] TextureMapperLayer uses intermediate surfaces too eagerly
Comment 1 Noam Rosenthal 2012-04-27 15:39:09 PDT
Created attachment 139293 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-04-29 04:00:08 PDT
Comment on attachment 139293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139293&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:221
> +        return MoreThanOneDescendantWithContent;

MultipleDecendantsWithContent

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:231
> +            count = 1;

What is the idea with setting it to 1 here and continue iterating? wont you end inside the same if and return MoreThanOne?

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:254
> +    bool mightHaveOverlaps = countDescendantsWithContent() == MoreThanOneDescendantWithContent;

canOverlap?
Comment 3 Noam Rosenthal 2012-04-29 12:04:12 PDT
Created attachment 139404 [details]
Patch
Comment 4 WebKit Review Bot 2012-04-30 07:07:26 PDT
Comment on attachment 139404 [details]
Patch

Clearing flags on attachment: 139404

Committed r115629: <http://trac.webkit.org/changeset/115629>
Comment 5 WebKit Review Bot 2012-04-30 07:07:31 PDT
All reviewed patches have been landed.  Closing bug.