Bug 85093

Summary:

[chromium] Allow WebMediaPlayerClientImpl to switch clients

Product:

WebKit

Reporter:

Adrienne Walker <enne>

Component:

New Bugs

Assignee:

Adrienne Walker <enne>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

enne, eric.carlson, feature-media-reviews, fischman, jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

85125

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Clang fixes	none

Adrienne Walker

Reported 2012-04-27 13:19:15 PDT

[chromium] Allow WebMediaPlayerClientImpl to switch clients

Attachments
Patch (2.16 KB, patch) 2012-04-27 13:26 PDT, Adrienne Walker	no flags	Details Formatted Diff Diff
Patch (9.11 KB, patch) 2012-04-27 15:20 PDT, Adrienne Walker	no flags	Details Formatted Diff Diff
Clang fixes (9.10 KB, patch) 2012-05-04 18:23 PDT, Adrienne Walker	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adrienne Walker

Comment 1 2012-04-27 13:26:50 PDT

Created attachment 139258 [details] Patch

Adrienne Walker

Comment 2 2012-04-27 13:27:31 PDT

Chromium bug: http://code.google.com/p/chromium/issues/detail?id=125113

James Robinson

Comment 3 2012-04-27 13:35:28 PDT

Comment on attachment 139258 [details] Patch Yup. Any thoughts on test? We can't really do a window->window transfer in a layout test, but we should be able to do that in a content or browser test, right?

Adrienne Walker

Comment 4 2012-04-27 13:38:22 PDT

(In reply to comment #3) > (From update of attachment 139258 [details]) > Yup. > > Any thoughts on test? We can't really do a window->window transfer in a layout test, but we should be able to do that in a content or browser test, right? Yeah, I was a little unsure about this too. I might be able to write a unit test to handle the underlying situation (switching clients); let me give that a go first before falling back on a content or browser test.

Adrienne Walker

Comment 5 2012-04-27 15:20:34 PDT

Created attachment 139288 [details] Patch

Adrienne Walker

Comment 6 2012-04-27 15:21:01 PDT

(In reply to comment #5) > Created an attachment (id=139288) [details] > Patch Now with unit tests.

James Robinson

Comment 7 2012-04-27 15:35:05 PDT

Comment on attachment 139288 [details] Patch Whee!

WebKit Review Bot

Comment 8 2012-04-27 19:55:07 PDT

Comment on attachment 139288 [details] Patch Clearing flags on attachment: 139288 Committed r115529: <http://trac.webkit.org/changeset/115529>