Bug 85087
| Summary: | check-webkit-style sometimes does not allow creating scopes for RAII objects | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | vollick |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | dpranke |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
vollick
check-webkit-style rejected at the following code:
if (!visible) {
{
DebugScopedSetImplThread impl;
m_layerTreeHost->didBecomeInvisibleOnImplThread(m_layerTreeHostImpl.get());
}
... other code that must execute when !visible, but when impl is out of scope ...
The style check failed because the second curly brace wasn't on the previous line, but I think that it should be fine where it is.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |