Bug 8507

Summary: Compilation fixes for building on gcc 4.0.2, and without precomp headers
Product: WebKit Reporter: Kevin Ollivier <kevino>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 8515    
Attachments:
Description Flags
Patch for compilation fixes.
darin: review-
Compilation fixes patch, with requested changes. darin: review+

Description Kevin Ollivier 2006-04-20 23:29:38 PDT
This patch contains the fixes needed to build JSCore and WebCore on Win/Mac/Linux without precompiled headers, as well as fixes needed for gcc 4.0.2. It also resolves two minor issues with undefined behavior on non-supported platforms, specifically defining Unicode support to use ICU in all cases outside of KDE, and defining PlatformCursor to void* when it hasn't been defined by the platform yet.
Comment 1 Kevin Ollivier 2006-04-20 23:31:09 PDT
Created attachment 7865 [details]
Patch for compilation fixes.
Comment 2 Darin Adler 2006-04-20 23:58:37 PDT
Comment on attachment 7865 [details]
Patch for compilation fixes.

Looks good. I see three problems:

    1) The include for pthread.h should be !PLATFORM(WIN_OS), not !PLATFORM(WIN)

    2) Assertions.cpp should use <stdio.h>, <stdarg.h>, and <string.h>, not "stdio.h", etc.

    3) +#elseif defined(__APPLE__)

No such thing as #elseif. It's #elif.

That issue (3) seems serious enough that we should not land it, so r-. But if you fix those 3 things, then this looks good to go.
Comment 3 Kevin Ollivier 2006-04-21 01:23:36 PDT
Created attachment 7867 [details]
Compilation fixes patch, with requested changes.
Comment 4 Kevin Ollivier 2006-04-21 01:27:05 PDT
Thanks, I've made the changes you requested. Believe it or not, #3 actually does compile with at least gcc4, which is why I didn't catch it. 
Comment 5 Darin Adler 2006-04-21 22:06:27 PDT
Comment on attachment 7867 [details]
Compilation fixes patch, with requested changes.

r=me