Summary: | Compilation fixes for building on gcc 4.0.2, and without precomp headers | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kevin Ollivier <kevino> | ||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 8515 | ||||||||
Attachments: |
|
Description
Kevin Ollivier
2006-04-20 23:29:38 PDT
Created attachment 7865 [details]
Patch for compilation fixes.
Comment on attachment 7865 [details]
Patch for compilation fixes.
Looks good. I see three problems:
1) The include for pthread.h should be !PLATFORM(WIN_OS), not !PLATFORM(WIN)
2) Assertions.cpp should use <stdio.h>, <stdarg.h>, and <string.h>, not "stdio.h", etc.
3) +#elseif defined(__APPLE__)
No such thing as #elseif. It's #elif.
That issue (3) seems serious enough that we should not land it, so r-. But if you fix those 3 things, then this looks good to go.
Created attachment 7867 [details]
Compilation fixes patch, with requested changes.
Thanks, I've made the changes you requested. Believe it or not, #3 actually does compile with at least gcc4, which is why I didn't catch it. Comment on attachment 7867 [details]
Compilation fixes patch, with requested changes.
r=me
|