Bug 85065

Summary: [Gtk][DOM Bindings] Conditional string in implementation file generated in wrong place after 113450
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-04-27 07:54:12 PDT
In revision 113450[1] the conditional string in implementation file was moved above the inclusion of WebCore (and other) headers. This reverts the reverse changes that were made in revision 111914, making builds again prone towards failure when disabling specific features (Geolocation for instance). [1] http://trac.webkit.org/changeset/113450 [2] http://trac.webkit.org/changeset/111914
Attachments
Patch (4.83 KB, patch)
2012-04-27 07:59 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-04-27 07:59:58 PDT
Created attachment 139202 [details] Patch
Zan Dobersek
Comment 2 2012-04-27 09:26:26 PDT
Comment on attachment 139202 [details] Patch Clearing flags on attachment: 139202 Committed r115438: <http://trac.webkit.org/changeset/115438>
Zan Dobersek
Comment 3 2012-04-27 09:26:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.