Bug 85052

Summary: [chromium] Disables a few webkit_unittests.
Product: WebKit Reporter: Marcus Bulach <bulach>
Component: New BugsAssignee: Marcus Bulach <bulach>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, isherman, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Marcus Bulach
Reported 2012-04-27 05:03:16 PDT
[chromium] Disables a few webkit_unittests.
Attachments
Patch (2.75 KB, patch)
2012-04-27 05:04 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Patch (2.98 KB, patch)
2012-04-27 08:04 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Patch (3.00 KB, patch)
2012-04-27 08:11 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Marcus Bulach
Comment 1 2012-04-27 05:04:16 PDT
Created attachment 139173 [details] Patch
Peter Beverloo
Comment 2 2012-04-27 05:06:28 PDT
SGTM.
WebKit Review Bot
Comment 3 2012-04-27 05:24:04 PDT
Comment on attachment 139173 [details] Patch Clearing flags on attachment: 139173 Committed r115421: <http://trac.webkit.org/changeset/115421>
WebKit Review Bot
Comment 4 2012-04-27 05:24:08 PDT
All reviewed patches have been landed. Closing bug.
Marcus Bulach
Comment 5 2012-04-27 08:04:53 PDT
Reopening to attach new patch.
Marcus Bulach
Comment 6 2012-04-27 08:04:56 PDT
Created attachment 139203 [details] Patch
Peter Beverloo
Comment 7 2012-04-27 08:07:43 PDT
Please amend the ChangeLog descriptions to say why you are disabling them, because this isn't clear for anyone reading the logs. Thanks!
Marcus Bulach
Comment 8 2012-04-27 08:11:49 PDT
Created attachment 139206 [details] Patch
Peter Beverloo
Comment 9 2012-04-27 08:12:20 PDT
SGTM.
Marcus Bulach
Comment 10 2012-04-27 08:14:12 PDT
Committed r115433: <http://trac.webkit.org/changeset/115433>
Dimitri Glazkov (Google)
Comment 11 2012-04-27 09:31:59 PDT
Reverted r115421 for reason: Enable unit tests again. Committed r115440: <http://trac.webkit.org/changeset/115440>
Dimitri Glazkov (Google)
Comment 12 2012-04-27 09:33:43 PDT
Reverted r115433 for reason: Enable unit tests again. Committed r115441: <http://trac.webkit.org/changeset/115441>
Stephen Chenney
Comment 13 2013-04-09 17:06:05 PDT
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.
Note You need to log in before you can comment on or make changes to this bug.