Bug 85048

Summary:

[EFL] ewk_view navigation_policy_decision() input parameters should be extended

Product:

WebKit

Reporter:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Component:

WebKit EFL

Assignee:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

85006

Attachments:

Description	Flags
new parameter for ewk_view navigation_policy_decision()	none
new parameter for ewk_view navigation_policy_decision()	none
new parameter for ewk_view navigation_policy_decision()	tonikitoo: review+, webkit.review.bot: commit-queue-
to be landed.	none

Mikhail Pozdnyakov

Reported 2012-04-27 04:25:07 PDT

ewk_view navigation_policy_decision() input parameters should be extended with navigation type info in order to provide needed logging for bug85006

Attachments
new parameter for ewk_view navigation_policy_decision() (7.21 KB, patch) 2012-04-27 04:58 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
new parameter for ewk_view navigation_policy_decision() (7.24 KB, patch) 2012-04-27 05:13 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
new parameter for ewk_view navigation_policy_decision() (7.38 KB, patch) 2012-05-11 06:44 PDT, Mikhail Pozdnyakov	tonikitoo: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
to be landed. (7.18 KB, patch) 2012-05-20 05:00 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mikhail Pozdnyakov

Comment 1 2012-04-27 04:58:24 PDT

Created attachment 139172 [details] new parameter for ewk_view navigation_policy_decision()

Mikhail Pozdnyakov

Comment 2 2012-04-27 05:13:01 PDT

Created attachment 139174 [details] new parameter for ewk_view navigation_policy_decision()

Gyuyoung Kim

Comment 3 2012-05-02 06:07:08 PDT

Comment on attachment 139174 [details] new parameter for ewk_view navigation_policy_decision() Looks good to me.

Antonio Gomes

Comment 4 2012-05-09 12:49:40 PDT

Comment on attachment 139174 [details] new parameter for ewk_view navigation_policy_decision() View in context: https://bugs.webkit.org/attachment.cgi?id=139174&action=review > Source/WebKit/efl/ChangeLog:13 > + [EFL] ewk_view navigation_policy_decision() input parameters should be extended > + https://bugs.webkit.org/show_bug.cgi?id=85048 > + > + Reviewed by NOBODY (OOPS!). > + > + Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType. > + Extended ewk_view navigation_policy_decision() input parameters with new > + navigationType parameter. > + > + * WebCoreSupport/AssertMatchingEnums.cpp: > + * WebCoreSupport/FrameLoaderClientEfl.cpp: I think you could say why it is needed.

Antonio Gomes

Comment 5 2012-05-09 13:01:16 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=139174&action=review > Source/WebKit/efl/ChangeLog:13 > + [EFL] ewk_view navigation_policy_decision() input parameters should be extended > + https://bugs.webkit.org/show_bug.cgi?id=85048 > + > + Reviewed by NOBODY (OOPS!). > + > + Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType. > + Extended ewk_view navigation_policy_decision() input parameters with new > + navigationType parameter. > + > + * WebCoreSupport/AssertMatchingEnums.cpp: > + * WebCoreSupport/FrameLoaderClientEfl.cpp: I think you could say why it is needed.

Mikhail Pozdnyakov

Comment 6 2012-05-11 06:44:06 PDT

Created attachment 141402 [details] new parameter for ewk_view navigation_policy_decision()

Mikhail Pozdnyakov

Comment 7 2012-05-11 06:44:57 PDT

(In reply to comment #5) > View in context: https://bugs.webkit.org/attachment.cgi?id=139174&action=review > > > Source/WebKit/efl/ChangeLog:13 > > + [EFL] ewk_view navigation_policy_decision() input parameters should be extended > > + https://bugs.webkit.org/show_bug.cgi?id=85048 > > + > > + Reviewed by NOBODY (OOPS!). > > + > > + Introduced new enum Ewk_Navigation_Type cloning WebCore::NavigationType. > > + Extended ewk_view navigation_policy_decision() input parameters with new > > + navigationType parameter. > > + > > + * WebCoreSupport/AssertMatchingEnums.cpp: > > + * WebCoreSupport/FrameLoaderClientEfl.cpp: > > I think you could say why it is needed. Fixed.

WebKit Review Bot

Comment 8 2012-05-18 13:36:45 PDT

Comment on attachment 141402 [details] new parameter for ewk_view navigation_policy_decision() Rejecting attachment 141402 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 1 FAILED at 245. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/efl/ewk/ewk_private.h.rej patching file Source/WebKit/efl/ewk/ewk_view.cpp Hunk #1 succeeded at 3994 (offset 91 lines). Hunk #2 succeeded at 4004 (offset 91 lines). patching file Source/WebKit/efl/ewk/ewk_view.h Hunk #1 succeeded at 179 (offset 1 line). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12727459

Mikhail Pozdnyakov

Comment 9 2012-05-20 05:00:58 PDT

Created attachment 142900 [details] to be landed.

WebKit Review Bot

Comment 10 2012-05-20 18:24:19 PDT

Comment on attachment 142900 [details] to be landed. Clearing flags on attachment: 142900 Committed r117720: <http://trac.webkit.org/changeset/117720>

WebKit Review Bot

Comment 11 2012-05-20 18:24:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.