Bug 85047

Summary: [EFL][DRT] EFL should sanitize pulseaudio module configuration too
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: WebKit EFLAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, gustavo, gyuyoung.kim, lucas.de.marchi, mrobinson, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Moving pulseaudio unload/restore to shared class none

Dominik Röttsches (drott)
Reported 2012-04-27 04:17:17 PDT
We would like to reuse the GTK pulseaudio sanitization.
Attachments
Moving pulseaudio unload/restore to shared class (11.23 KB, patch)
2012-04-27 04:35 PDT, Dominik Röttsches (drott) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-04-27 04:35:31 PDT
Created attachment 139168 [details] Moving pulseaudio unload/restore to shared class Feedback from GTK folks is very welcome.
Dirk Pranke
Comment 2 2012-04-27 11:43:45 PDT
Comment on attachment 139168 [details] Moving pulseaudio unload/restore to shared class I'm R+'ing this because you presumably didn't write this code and are just moving it around, but the code should really be using the FileSystem and Executive classes, and have some unit tests rather than talking to os.path and subprocess directly :(.
WebKit Review Bot
Comment 3 2012-04-27 13:06:44 PDT
Comment on attachment 139168 [details] Moving pulseaudio unload/restore to shared class Clearing flags on attachment: 139168 Committed r115478: <http://trac.webkit.org/changeset/115478>
WebKit Review Bot
Comment 4 2012-04-27 13:06:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.