Bug 85046

Summary: [EFL] Add OwnPtr specialization for Eina_Hash.
Product: WebKit Reporter: Michal Pakula vel Rutka <mpakulavelrutka>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 74921    
Attachments:
Description Flags
proposed patch
none
fixed order none

Michal Pakula vel Rutka
Reported 2012-04-27 03:19:26 PDT
OwnPtr does not have as support for Eina_Hash, this patch adds implementation so it can be used by https://bugs.webkit.org/show_bug.cgi?id=74921.
Attachments
proposed patch (1.66 KB, patch)
2012-04-27 03:22 PDT, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
fixed order (1.81 KB, patch)
2012-05-07 02:21 PDT, Michal Pakula vel Rutka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michal Pakula vel Rutka
Comment 1 2012-04-27 03:22:06 PDT
Created attachment 139164 [details] proposed patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-04-28 12:09:47 PDT
Comment on attachment 139164 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=139164&action=review > Source/WTF/wtf/OwnPtrCommon.h:47 > +typedef struct _Eina_Hash Eina_Hash; Please keep this list (as well as the others) sorted.
Michal Pakula vel Rutka
Comment 3 2012-05-07 02:21:22 PDT
Created attachment 140496 [details] fixed order Fixed alphabetical order in OwnPtrCommon.h and moved new method above other Eina_* method as order is not kept there.
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-05-09 10:51:45 PDT
LGTM.
Gyuyoung Kim
Comment 5 2012-05-09 21:58:20 PDT
Comment on attachment 140496 [details] fixed order Looks good. Thanks.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-05-10 07:04:15 PDT
Comment on attachment 140496 [details] fixed order Clearing flags on attachment: 140496 Committed r116640: <http://trac.webkit.org/changeset/116640>
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-05-10 07:04:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.