Summary: | [BlackBerry] Support html5 download attribute | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mary Wu <mawu> | ||||||||
Component: | WebKit BlackBerry | Assignee: | Mary Wu <mawu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | joenotcharles, leo.yang, liachen, logingx, tonikitoo, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mary Wu
2012-04-27 02:56:08 PDT
Created attachment 139163 [details]
Patch
setSuggestSaveName should be setSuggestedSaveName. Too tired to look at the rest right now. (In reply to comment #1) > Created an attachment (id=139163) [details] > Patch Looks good to me. Mary, did you test CrossThreadResourceRequestData or redirect? (In reply to comment #4) > Mary, did you test CrossThreadResourceRequestData or redirect? Good catch - the new member variable needs to be added to that too. Also I just noticed it's missing m_overrideContentType and m_targetType. (In reply to comment #5) > (In reply to comment #4) > > Mary, did you test CrossThreadResourceRequestData or redirect? > > Good catch - the new member variable needs to be added to that too. Also I just noticed it's missing m_overrideContentType and m_targetType. thanks, will add in CrossThreadResourceRequestData. also for the missing members, will create separate pr to track. Created attachment 139936 [details]
Patch
LGTM Comment on attachment 139936 [details] Patch Rejecting attachment 139936 [details] from commit-queue. mary.wu@torchmobile.com.cn does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 139936 [details] Patch Rejecting attachment 139936 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ED at 244. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp.rej patching file Source/WebKit/blackberry/Api/WebPage.cpp patching file Source/WebKit/blackberry/Api/WebPage_p.h patching file Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antonio Go..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12507050 Created attachment 140462 [details]
Patch
Comment on attachment 140462 [details] Patch Clearing flags on attachment: 140462 Committed r116265: <http://trac.webkit.org/changeset/116265> All reviewed patches have been landed. Closing bug. |