| Summary: | [chromium] Separate IOSurface layer type from texture layers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, cc-bugs, dglazkov, fishd, tkent+wkapi, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
James Robinson
2012-04-26 22:29:02 PDT
Created attachment 139133 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Attachment 139133 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 139133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=139133&action=review R=me. > Source/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:52 > + // FIXME: it seems there is no layer renderer / GraphicsContext3D available here. Ideally we > + // would like to delete m_ioSurfaceTextureId. This feels kind of like a job for TextureManager/ManagedTexture, but those classes aren't quite smart enough to handle IO surface textures. It's a "normal" texture, just needs a deleteTexture() call. |