Bug 85030 – [chromium] Separate IOSurface layer type from texture layers

• Component: New Bugs
• Status: RESOLVED FIXED

[James Robinson]

[chromium] Separate IOSurface layer type from texture layers

[James Robinson]

Created attachment 139133 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Attachment 139133 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebKit/chromium/src/WebIOSurfaceLayer.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adrienne Walker]

Comment on attachment 139133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139133&action=review

R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:52
> +    // FIXME: it seems there is no layer renderer / GraphicsContext3D available here. Ideally we
> +    // would like to delete m_ioSurfaceTextureId.

This feels kind of like a job for TextureManager/ManagedTexture, but those classes aren't quite smart enough to handle IO surface textures.

[James Robinson]

It's a "normal" texture, just needs a deleteTexture() call.

[James Robinson]

http://trac.webkit.org/changeset/115509