Bug 85011

Summary: Remove RegisterFile::end()/m_end
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: REOPENED    
Severity: Normal CC: gustavo, koivisto, pnormand, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Remove now bogus NDEBUG ifdef none

Oliver Hunt
Reported 2012-04-26 15:26:15 PDT
Remove RegisterFile::end()/m_end
Attachments
Patch (28.34 KB, patch)
2012-04-26 15:54 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Remove now bogus NDEBUG ifdef (29.06 KB, patch)
2012-04-26 16:18 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2012-04-26 15:54:40 PDT
Created attachment 139087 [details] Patch
Early Warning System Bot
Comment 2 2012-04-26 16:07:45 PDT
Comment on attachment 139087 [details] Patch Attachment 139087 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12534029
Build Bot
Comment 3 2012-04-26 16:10:44 PDT
Comment on attachment 139087 [details] Patch Attachment 139087 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12548026
Philippe Normand
Comment 4 2012-04-26 16:15:44 PDT
Comment on attachment 139087 [details] Patch Attachment 139087 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12552041
Oliver Hunt
Comment 5 2012-04-26 16:18:30 PDT
Created attachment 139090 [details] Remove now bogus NDEBUG ifdef
Oliver Hunt
Comment 6 2012-04-26 17:06:19 PDT
Committed r115388: <http://trac.webkit.org/changeset/115388>
Oliver Hunt
Comment 8 2012-04-28 11:47:47 PDT
(In reply to comment #7) > This patch seems to have caused massive swings in number of tests in http://webkit-perf.appspot.com on all JSC using (Mac Lion and Qt) bots. > > 10% regression in Dromaeo/dom-traverse: > > http://webkit-perf.appspot.com/graph.html#tests=[[40020,2001,32196]]&sel=1335481319023.587,1335500151119.3953,1212.7659574468084,2680.851063829787&displayrange=7&datatype=running > > 50% regression in DOM/Template > > http://webkit-perf.appspot.com/graph.html#tests=[[110,2001,32196]]&sel=1335480730398.3186,1335502455543.162,6.808510638297875,30.638297872340424&displayrange=7&datatype=running > > 50% progression in Bindings/event-target-wrapper (Lion bot only, not Qt bots) > > http://webkit-perf.appspot.com/graph.html#tests=[[8062,2001,32196]]&sel=1335478825629.3184,1335502278508.2844,0,1468.0851063829787&displayrange=7&datatype=running That is certainly sad making. Could you file a separate bug on that, assign it to me -- i'll look into it on monday. Doesn't make sense that this would cause any variation (if anything it should reduce variation, and improve overall performance. grumble.
Antti Koivisto
Comment 9 2012-04-29 01:38:03 PDT
Filed bug 85155.
Oliver Hunt
Comment 10 2012-05-02 12:17:36 PDT
Reverted r115388 for reason: This caused many weird performance problems, and needs to be landed in pieces. Committed r115861: <http://trac.webkit.org/changeset/115861>
Note You need to log in before you can comment on or make changes to this bug.