Bug 84996

Summary: Fix missing sourceState change on MEDIA_ERR_SOURCE_NOT_SUPPORTED error.
Product: WebKit Reporter: Aaron Colwell <acolwell>
Component: MediaAssignee: Aaron Colwell <acolwell>
Severity: Normal CC: eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 83607    
Description Flags
Patch none

Description Aaron Colwell 2012-04-26 13:04:07 PDT
In cases where appending data with webkitSourceAppend() triggers a MEDIA_ERR_SOURCE_NOT_SUPPORTED error, the m_sourceState was not being reset to SOURCE_CLOSED. This was causing future calls to webkitSourceAppend() after the error to actually make calls to m_player->sourceAppend() instead of throwing an INVALID_STATE_ERR exception like they were supposed to. 

This was causing crashes in Chromium because the code assumes that once it reports the error to WebKit it won't get any more calls to m_player->sourceAppend().
Comment 1 Aaron Colwell 2012-04-26 13:09:09 PDT
Created attachment 139052 [details]
Comment 2 WebKit Review Bot 2012-04-26 15:33:31 PDT
Comment on attachment 139052 [details]

Clearing flags on attachment: 139052

Committed r115380: <http://trac.webkit.org/changeset/115380>
Comment 3 WebKit Review Bot 2012-04-26 15:33:36 PDT
All reviewed patches have been landed.  Closing bug.