Bug 84985

Summary:

Counter still gets incremented when counter-increment is set to none

Product:

WebKit

Reporter:

Yi Shen <max.hong.shen>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

carol, commit-queue, esprehn+autocc, esprehn, hyatt, inferno, jchaffraix, macpherson, menard, ojan.autocc, rniwa, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
First try	jchaffraix: review-
clear counter increment when its value is none	none

Description Yi Shen 2012-04-26 12:01:20 PDT

http://test.csswg.org/suites/css2.1/20110323/html4/counter-increment-053.htm test fails. According to w3c spec (http://www.w3.org/TR/CSS2/generate.html#propdef-counter-increment), A value of 'none' on its own means no counters are reset, resp. incremented.

Comment 1 Yi Shen 2012-04-26 12:46:11 PDT

Created attachment 139048 [details]
First try

Comment 2 Brent Fulgham 2012-11-14 00:04:41 PST

Comment on attachment 139048 [details]
First try

This patch looks correct. Is there a reason it has not been reviewed? Does it violate some aspect of the counter specification?

Comment 3 Tony Chang 2012-11-14 10:57:27 PST

Elliott was in the counters code recently, maybe he would like to do an unofficial review?

Comment 4 Elliott Sprehn 2012-11-14 14:11:36 PST

I'll review later today, but looking quickly this doesn't seem right since you transform none into counter-increment: 0 for every counter which creates implicit scopes.

Comment 5 Yi Shen 2012-12-10 11:30:23 PST

Thanks for comments, guys. It is an old patch and I will rework on it.
(In reply to comment #4)
> I'll review later today, but looking quickly this doesn't seem right since you transform none into counter-increment: 0 for every counter which creates implicit scopes.

Comment 6 Julien Chaffraix 2013-02-28 10:58:13 PST

Comment on attachment 139048 [details]
First try

Punting the patch out of the review queue based on Elliot's comment. If you come up with a new patch covering implicit scopes, I would be happy to look at it.

Comment 7 Yi Shen 2013-03-21 16:09:24 PDT

Created attachment 194371 [details]
clear counter increment when its value is none

Comment 8 WebKit Commit Bot 2013-04-08 10:39:37 PDT

Comment on attachment 194371 [details]
clear counter increment when its value is none

Clearing flags on attachment: 194371

Committed r147930: <http://trac.webkit.org/changeset/147930>

Comment 9 WebKit Commit Bot 2013-04-08 10:39:40 PDT

All reviewed patches have been landed.  Closing bug.