Bug 84969

Summary: Implement StyleSheetInternal copying
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kling, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77745    
Attachments:
Description Flags
patch kling: review+, webkit-ews: commit-queue-

Description Antti Koivisto 2012-04-26 09:08:32 PDT
We need to be able to copy stylesheets to cache them. Copying is already implement for most of the stylesheet data types but StyleSheetInternal::copy() is still missing.
Comment 1 Antti Koivisto 2012-04-26 10:37:08 PDT
Created attachment 139025 [details]
patch
Comment 2 Early Warning System Bot 2012-04-26 10:49:05 PDT
Comment on attachment 139025 [details]
patch

Attachment 139025 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12525915
Comment 3 Andreas Kling 2012-04-26 11:21:09 PDT
Comment on attachment 139025 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139025&action=review

r=me with GCC appeased somehow.

> Source/WebCore/ChangeLog:8
> +        We need to be able to copy stylesheets to cache them. Copying is already implement for

Typo, implemented.

> Source/WebCore/ChangeLog:28
> +            Add equality comparison operator to CSSParseMode. This will be needed to determine

Typo CSSParserMode.
Comment 4 Antti Koivisto 2012-04-26 11:44:26 PDT
http://trac.webkit.org/changeset/115336 (with a build fix)