Bug 84950

Summary: [GTK] Massive media tests failures since r115288
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mhahnenberg, spena, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Philippe Normand
Reported 2012-04-26 06:34:17 PDT
Lots of tests now timing out. It seems the GStreamer media player does something wrong which has bad consequences on the memory management of the media elements. This works fine: run-webkit-tests --run-singly --gtk media But when the DRT instance is reused acrossed tests (default behavior) it triggers unexpected flakiness of the media suite.
Attachments
Patch (3.58 KB, patch)
2012-04-26 12:20 PDT, Mark Hahnenberg
no flags
Mark Hahnenberg
Comment 1 2012-04-26 08:02:31 PDT
I believe this has to do with the fact that we only have a properly implemented GCActivityCallback on platforms which have CoreFoundation, meaning we are now not doing any collection for those platforms without CoreFoundation when we call GCController::garbageCollectSoon(). This is obviously bad. I'd imagine that this issue manifests itself in the media tests because of the fact that they're dealing with very large things that need to be collected pretty quickly when they die to prevent memory bloat.
Mark Hahnenberg
Comment 2 2012-04-26 12:20:48 PDT
Philippe Normand
Comment 3 2012-04-26 12:52:45 PDT
I've just tested the patch locally and it fixes the media suite flakyness. Thanks Mark!
WebKit Review Bot
Comment 4 2012-04-26 15:52:53 PDT
Comment on attachment 139040 [details] Patch Clearing flags on attachment: 139040 Committed r115383: <http://trac.webkit.org/changeset/115383>
WebKit Review Bot
Comment 5 2012-04-26 15:52:57 PDT
All reviewed patches have been landed. Closing bug.
Yong Li
Comment 6 2012-06-26 14:22:25 PDT
How about moving Timer/SharedTimer into WTF as is done for String?
Mark Hahnenberg
Comment 7 2012-06-26 14:25:19 PDT
(In reply to comment #6) > How about moving Timer/SharedTimer into WTF as is done for String? Yes, that is what I'd like to do when I get around to it. If you'd like to do that, you're more than welcome! :-)
Note You need to log in before you can comment on or make changes to this bug.