Summary: | [Qt][WK2] Tap highlight should have a delay not to interfere with panning | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andras Becsi <abecsi> | ||||||
Component: | New Bugs | Assignee: | Andras Becsi <abecsi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | hausmann, jturcotte, kenneth, menard, webkit.review.bot, zoltan | ||||||
Priority: | P3 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Andras Becsi
2012-04-26 06:22:25 PDT
Created attachment 138987 [details]
proposed patch
Created attachment 138990 [details]
proposed patch
Comment on attachment 138990 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=138990&action=review > Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp:102 > +void QtTapGestureRecognizer::tapHighlightTimeout() We are in the TAP gesture recognizer,,,.. maybe highlightTimeout is sufficient > Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.h:39 > +const int tapHighlightThreshold = 80; highlightPostponeTime would make more sense > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:499 > + // Early return since this was a touch end event. touch-end event Landed in http://trac.webkit.org/changeset/115311. Comment on attachment 138990 [details]
proposed patch
Clearing flags.
|