Bug 84948

Summary: [Qt][WK2] Tap highlight should have a delay not to interfere with panning
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: New BugsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, jturcotte, kenneth, menard, webkit.review.bot, zoltan
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
proposed patch none

Andras Becsi
Reported 2012-04-26 06:22:25 PDT
Start the tap highlight animation after a slight delay so that pan gestures do not result in flashing highlight rects which slow down flicking, especially for continuous pan gestures.
Attachments
proposed patch (6.77 KB, patch)
2012-04-26 06:41 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
proposed patch (6.71 KB, patch)
2012-04-26 06:47 PDT, Andras Becsi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2012-04-26 06:41:53 PDT
Created attachment 138987 [details] proposed patch
Andras Becsi
Comment 2 2012-04-26 06:47:49 PDT
Created attachment 138990 [details] proposed patch
Kenneth Rohde Christiansen
Comment 3 2012-04-26 06:56:06 PDT
Comment on attachment 138990 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=138990&action=review > Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.cpp:102 > +void QtTapGestureRecognizer::tapHighlightTimeout() We are in the TAP gesture recognizer,,,.. maybe highlightTimeout is sufficient > Source/WebKit2/UIProcess/qt/QtTapGestureRecognizer.h:39 > +const int tapHighlightThreshold = 80; highlightPostponeTime would make more sense > Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp:499 > + // Early return since this was a touch end event. touch-end event
Andras Becsi
Comment 4 2012-04-26 07:14:00 PDT
Landed in http://trac.webkit.org/changeset/115311.
Andras Becsi
Comment 5 2012-04-26 07:14:19 PDT
Comment on attachment 138990 [details] proposed patch Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.