Bug 84944

Summary: [EFL] [DRT] Unskip passing tests related to editing commands
Product: WebKit Reporter: Sudarsana Nagineni (babu) <naginenis>
Component: WebKit EFLAssignee: Sudarsana Nagineni (babu) <naginenis>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cq-02
none
Patch none

Sudarsana Nagineni (babu)
Reported 2012-04-26 04:43:04 PDT
Many tests related to editing commands are passing now on EFL port. I am going to unksip them from the skip list.
Attachments
patch (4.47 KB, patch)
2012-04-26 04:49 PDT, Sudarsana Nagineni (babu) 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cq-02 (6.14 MB, application/zip)
2012-04-27 09:59 PDT, WebKit Review Bot 		no flags
Details
Patch (deleted)
2012-04-27 12:41 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sudarsana Nagineni (babu)
Comment 1 2012-04-26 04:49:57 PDT
Created attachment 138978 [details] patch Unskip passing tests
Sudarsana Nagineni (babu)
Comment 2 2012-04-26 05:00:27 PDT
Checked on two machines, no regressions found.
WebKit Review Bot
Comment 3 2012-04-27 09:59:41 PDT
Comment on attachment 138978 [details] patch Rejecting attachment 138978 [details] from commit-queue. New failing tests: fast/workers/storage/interrupt-database.html Full output: http://queues.webkit.org/results/12559258
WebKit Review Bot
Comment 4 2012-04-27 09:59:47 PDT
Created attachment 139220 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Sudarsana Nagineni (babu)
Comment 5 2012-04-27 12:20:11 PDT
I don't understand what went wrong. Tested again on my machine and no regression found. Without patch: => Results: 21188/29312 tests passed (72.3%) => Tests to be fixed (8124): 1 crash ( 0.0%) 195 text diff mismatch ( 2.4%) 29 image mismatch ( 0.4%) 7899 skipped (97.2%) Expected to fail, but passed: (4) Unexpected flakiness: text diff mismatch (1) Regressions: Unexpected text diff mismatch : (132) Regressions: Unexpected image mismatch : (9) Regressions: Unexpected crashes : (1) With patch: => Results: 21248/29312 tests passed (72.5%) => Tests to be fixed (8064): 1 crash ( 0.0%) 195 text diff mismatch ( 2.4%) 29 image mismatch ( 0.4%) 7839 skipped (97.2%) Expected to fail, but passed: (4) Unexpected flakiness: text diff mismatch (1) Regressions: Unexpected text diff mismatch : (132) Regressions: Unexpected image mismatch : (9) Regressions: Unexpected crashes : (1)
Sudarsana Nagineni (babu)
Comment 6 2012-04-27 12:41:38 PDT
Created attachment 139249 [details] Patch trying again
WebKit Review Bot
Comment 7 2012-04-27 16:22:27 PDT
Comment on attachment 139249 [details] Patch Clearing flags on attachment: 139249 Committed r115511: <http://trac.webkit.org/changeset/115511>
WebKit Review Bot
Comment 8 2012-04-27 16:22:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.