Bug 84943

Summary: [EFL] Several media layout tests need rebaselining
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, feature-media-reviews, gyuyoung.kim, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84949    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2012-04-26 04:29:36 PDT
The following media tests are failing and seem to require rebaselining: - media/media-controls-clone.html - media/video-empty-source.html - media/video-zoom-controls.html = TEXT
Attachments
Patch (4.77 KB, patch)
2012-04-26 04:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.50 KB, patch)
2012-04-27 11:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (5.50 KB, patch)
2012-04-27 11:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-04-26 04:32:52 PDT
Created attachment 138976 [details] Patch
Chris Dumez
Comment 2 2012-04-26 06:27:03 PDT
Comment on attachment 138976 [details] Patch Removing cq? flag since it will require further rebaselining once media/video-controls-rendering-toggle-display-none.html is fixed.
Chris Dumez
Comment 3 2012-04-26 06:45:37 PDT
These tests need rebaselining because of bug 82150 fix.
Chris Dumez
Comment 4 2012-04-27 11:19:37 PDT
Created attachment 139238 [details] Patch
Chris Dumez
Comment 5 2012-04-27 11:23:00 PDT
Created attachment 139240 [details] Patch Improve bug report title.
Eric Carlson
Comment 6 2012-04-27 11:36:38 PDT
Did you forget to set the r? flag?
Chris Dumez
Comment 7 2012-04-27 12:29:22 PDT
Is formal review needed for simple rebaselining?
Eric Carlson
Comment 8 2012-04-27 13:24:39 PDT
(In reply to comment #7) > Is formal review needed for simple rebaselining? No, but I don't know that I have ever seen a bug with only cq? so I wasn't sure if you actually meant to set it. I would probably be a good idea to leave a comment in a bug asking for a commit in a case like this.
WebKit Review Bot
Comment 9 2012-04-27 15:01:39 PDT
Comment on attachment 139240 [details] Patch Clearing flags on attachment: 139240 Committed r115499: <http://trac.webkit.org/changeset/115499>
WebKit Review Bot
Comment 10 2012-04-27 15:01:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.