Bug 84926 – [chromium] Remove guarded virtual methods from WebFilterOperation API

• Component: New Bugs
• Status: RESOLVED FIXED

[Dana Jansens]

[chromium] Cannot use guarded virtual methods in public API classes

[Dana Jansens]

Created attachment 138925 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 138925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138925&action=review

> Source/Platform/ChangeLog:3
> +        [chromium] Cannot use guarded virtual methods in public API classes

this is not a description of a bug (public API classes shouldn't allow guarded virtual methods, most likely) and it's not a good description of what this patch is changing. can you update it (and the WebCore/ChangeLog entry too)?

[Dana Jansens]

Created attachment 138931 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 138931 [details]
Patch for landing

Clearing flags on attachment: 138931

Committed r115291: <http://trac.webkit.org/changeset/115291>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Fisher (:fishd, Google)]

Comment on attachment 138931 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=138931&action=review

> Source/Platform/chromium/public/WebFilterOperation.h:74
> +    enum BasicComponentTransferFilterType {

"BasicComponentTransfer" appears both as part of the struct name as as
a prefix for the enum.  why duplicate the prefix?

[Dana Jansens]

Comment on attachment 138931 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=138931&action=review

>> Source/Platform/chromium/public/WebFilterOperation.h:74
>> +    enum BasicComponentTransferFilterType {
> 
> "BasicComponentTransfer" appears both as part of the struct name as as
> a prefix for the enum.  why duplicate the prefix?

Because it is a sub-FilterType specific to this class. There is a FilterType in the base class that specifies which subclass the operation is. This specifies which FilterType for a BasicComponentTransfer.