Bug 84925

Summary:

webkitpy: fix race in unit tests for manager_worker_broker

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

New Bugs

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, ojan, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
delete stray import	ojan: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03	none

Dirk Pranke

Reported 2012-04-25 18:55:33 PDT

webkitpy: fix race in unit tests for manager_worker_broker

Attachments
Patch (3.94 KB, patch) 2012-04-25 18:58 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
Patch (5.15 KB, patch) 2012-04-26 16:21 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
delete stray import (5.01 KB, patch) 2012-04-26 16:23 PDT, Dirk Pranke	ojan: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (6.55 MB, application/zip) 2012-04-27 08:34 PDT, WebKit Review Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2012-04-25 18:58:28 PDT

Created attachment 138923 [details] Patch

Ojan Vafai

Comment 2 2012-04-25 19:18:18 PDT

Comment on attachment 138923 [details] Patch Seems not ideal to have a default value that you only want to use in tests. How about leave the timeout value explicit and just passing timeout=None in the calling locations?

Dirk Pranke

Comment 3 2012-04-26 14:39:15 PDT

(In reply to comment #2) > (From update of attachment 138923 [details]) > Seems not ideal to have a default value that you only want to use in tests. How about leave the timeout value explicit and just passing timeout=None in the calling locations? That's a much better idea, thanks!

Dirk Pranke

Comment 4 2012-04-26 15:04:20 PDT

cancelling this patch ... after more testing, there's something else weird going on with this hang, and the join(None) by itself doesn't seem to fix it.

Dirk Pranke

Comment 5 2012-04-26 16:21:42 PDT

Created attachment 139091 [details] Patch

Dirk Pranke

Comment 6 2012-04-26 16:23:55 PDT

Created attachment 139093 [details] delete stray import

WebKit Review Bot

Comment 7 2012-04-27 08:34:11 PDT

Comment on attachment 139093 [details] delete stray import Attachment 139093 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12556235 New failing tests: fast/images/gif-large-checkerboard.html

WebKit Review Bot

Comment 8 2012-04-27 08:34:17 PDT

Created attachment 139211 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Dirk Pranke

Comment 9 2012-04-27 11:11:18 PDT

Committed r115452: <http://trac.webkit.org/changeset/115452>

Note You need to log in before you can comment on or make changes to this bug.