Bug 84916

Summary:

Placeholder view is immediately removed from hosting window upon entering full screen.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

85388

Attachments:

Description	Flags
Patch	darin: review+, buildbot: commit-queue-

Description Jer Noble 2012-04-25 17:45:26 PDT

Placeholder view is immediately removed from hosting window upon entering full screen.

Comment 1 Jer Noble 2012-04-25 17:48:46 PDT

Created attachment 138908 [details]
Patch

Comment 2 Darin Adler 2012-04-25 17:54:32 PDT

Comment on attachment 138908 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138908&action=review

> Source/WebKit/mac/WebView/WebFullScreenController.mm:457
> +    [[view superview] addSubview:otherView positioned:NSWindowAbove relativeTo:otherView];r114567

Oops.

Comment 3 Build Bot 2012-04-25 17:56:06 PDT

Comment on attachment 138908 [details]
Patch

Attachment 138908 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12522620

Comment 4 Darin Adler 2012-04-25 17:56:35 PDT

Comment on attachment 138908 [details]
Patch

r=me but please don't check in the typo since its ill break the build!

What about test coverage?

Comment 5 Jer Noble 2012-04-25 19:46:37 PDT

(In reply to comment #4)
> (From update of attachment 138908 [details])
> r=me but please don't check in the typo since its ill break the build!

Whoops. I fixed that in the WebKit2 side of the patch; I'll fix it here too. 

> What about test coverage?

This issue was found by manual testing, and this fix will require manual testing too.

Comment 6 Jer Noble 2012-04-26 09:51:45 PDT

Committed r115324: <http://trac.webkit.org/changeset/115324>