Bug 84898

Summary:

Biolab disaster crashes on ToT

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	fpizlo: review+

Oliver Hunt

Reported 2012-04-25 15:46:14 PDT

Biolab disaster crashes on ToT

Attachments
Patch (2.58 KB, patch) 2012-04-25 15:49 PDT, Oliver Hunt	fpizlo: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2012-04-25 15:49:31 PDT

Created attachment 138886 [details] Patch

Filip Pizlo

Comment 2 2012-04-25 15:52:36 PDT

Comment on attachment 138886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138886&action=review r=me with the simplification > Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp:115 > + InlineCallFrame& inlineCallFrame = codeBlock()->inlineCallFrames()[i]; > + CodeBlock* codeBlock = jsCast<FunctionExecutable*>(inlineCallFrame.executable.get())->baselineCodeBlockFor(inlineCallFrame.isCall ? CodeForCall : CodeForConstruct); baselineCodeBlockForInlineCallFrame(&codeBlock()->inlineCallFrames()[i])

Oliver Hunt

Comment 3 2012-04-25 15:57:15 PDT

Committed r115252: <http://trac.webkit.org/changeset/115252>

Oliver Hunt

Comment 4 2012-04-25 16:00:17 PDT

Committed r115253: <http://trac.webkit.org/changeset/115253>

Note You need to log in before you can comment on or make changes to this bug.