Bug 84877

Summary:

Layout Test fast/css/getPropertyValue-border.html is failing

Product:

WebKit

Reporter:

Hin-Chung Lam <hclam>

Component:

Tools / Tests

Assignee:

Marcus Bulach <bulach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bulach, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Hin-Chung Lam 2012-04-25 11:16:59 PDT

The following layout test is failing on chromium

fast/css/getPropertyValue-border.html

Probable cause:

Test starts failing since this change:
http://trac.webkit.org/changeset/115227

chromium.webkit flakiness bots results:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/css/getPropertyValue-border.html

Comment 1 Ryosuke Niwa 2012-04-25 12:42:19 PDT

I think this was caused by my last-minute change to use StringBuilder. Will land a build fix soon.

Comment 2 Ryosuke Niwa 2012-04-25 14:16:55 PDT

Fixed in http://trac.webkit.org/changeset/115244.

Comment 3 Marcus Bulach 2012-04-26 04:01:39 PDT

this test seems to be happy now:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2FgetPropertyValue-border.html

should we remove it from test_expections.txt?

Comment 4 Ryosuke Niwa 2012-04-26 04:41:21 PDT

Yes.

Comment 5 Marcus Bulach 2012-04-26 06:14:19 PDT

Reopening to attach new patch.

Comment 6 Marcus Bulach 2012-04-26 06:14:22 PDT

Created attachment 138985 [details]
Patch

Comment 7 Ryosuke Niwa 2012-04-26 12:10:39 PDT

Comment on attachment 138985 [details]
Patch

You can make these changes without a review.

Comment 8 WebKit Review Bot 2012-04-26 14:25:32 PDT

Comment on attachment 138985 [details]
Patch

Rejecting attachment 138985 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3678.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12553002

Comment 9 Ryosuke Niwa 2012-04-26 14:44:24 PDT

Comment on attachment 138985 [details]
Patch

Done in http://trac.webkit.org/changeset/115371.