Bug 84877 – Layout Test fast/css/getPropertyValue-border.html is failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Hin-Chung Lam]

The following layout test is failing on chromium

fast/css/getPropertyValue-border.html

Probable cause:

Test starts failing since this change:
http://trac.webkit.org/changeset/115227

chromium.webkit flakiness bots results:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT - chromium.org&tests=fast/css/getPropertyValue-border.html

[Ryosuke Niwa]

I think this was caused by my last-minute change to use StringBuilder. Will land a build fix soon.

[Ryosuke Niwa]

Fixed in http://trac.webkit.org/changeset/115244.

[Marcus Bulach]

this test seems to be happy now:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2FgetPropertyValue-border.html

should we remove it from test_expections.txt?

[Ryosuke Niwa]

Yes.

[Marcus Bulach]

Reopening to attach new patch.

[Marcus Bulach]

Created attachment 138985 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 138985 [details]
Patch

You can make these changes without a review.

[WebKit Review Bot]

Comment on attachment 138985 [details]
Patch

Rejecting attachment 138985 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3678.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ryosuke Ni..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12553002

[Ryosuke Niwa]

Comment on attachment 138985 [details]
Patch

Done in http://trac.webkit.org/changeset/115371.