Bug 84862

Summary: [BlackBerry] Possible JS re-entrancy caused by UI event handler
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
the patch
none
fix style
none
a fix for the previous patch
none
a fix none

Yong Li
Reported 2012-04-25 07:41:26 PDT
To avoid possible JS re-entrancy caused by UI events when page loading is deferred.
Attachments
the patch (28.42 KB, patch)
2012-04-25 07:42 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
fix style (28.45 KB, patch)
2012-04-25 08:04 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
a fix for the previous patch (1.88 KB, patch)
2012-04-25 15:05 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
a fix (1.25 KB, patch)
2012-12-13 14:54 PST, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-04-25 07:42:44 PDT
Created attachment 138808 [details] the patch
WebKit Review Bot
Comment 2 2012-04-25 07:46:49 PDT
Attachment 138808 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/Api/WebPage.cpp:3051: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebKit/blackberry/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yong Li
Comment 3 2012-04-25 08:02:13 PDT
Comment on attachment 138808 [details] the patch to fix style
Yong Li
Comment 4 2012-04-25 08:04:20 PDT
Created attachment 138811 [details] fix style
Antonio Gomes
Comment 5 2012-04-25 13:10:14 PDT
Comment on attachment 138811 [details] fix style very nice!
WebKit Review Bot
Comment 6 2012-04-25 14:22:12 PDT
Comment on attachment 138811 [details] fix style Clearing flags on attachment: 138811 Committed r115245: <http://trac.webkit.org/changeset/115245>
WebKit Review Bot
Comment 7 2012-04-25 14:22:25 PDT
All reviewed patches have been landed. Closing bug.
Yong Li
Comment 8 2012-04-25 15:05:48 PDT
Created attachment 138878 [details] a fix for the previous patch when double-checking the patch, I found a bug in the previous patch.
Yong Li
Comment 9 2012-04-25 15:06:55 PDT
reopening
WebKit Review Bot
Comment 10 2012-04-26 06:54:45 PDT
Comment on attachment 138878 [details] a fix for the previous patch Clearing flags on attachment: 138878 Committed r115308: <http://trac.webkit.org/changeset/115308>
WebKit Review Bot
Comment 11 2012-04-26 06:54:50 PDT
All reviewed patches have been landed. Closing bug.
Yong Li
Comment 12 2012-12-13 14:47:37 PST
reopen to fix a one-character bug in the patch
Yong Li
Comment 13 2012-12-13 14:54:01 PST
Created attachment 179346 [details] a fix
Rob Buis
Comment 14 2012-12-13 14:56:11 PST
Comment on attachment 179346 [details] a fix Obvious fix, obvious r+ :)
WebKit Review Bot
Comment 15 2012-12-13 15:42:33 PST
Comment on attachment 179346 [details] a fix Clearing flags on attachment: 179346 Committed r137671: <http://trac.webkit.org/changeset/137671>
WebKit Review Bot
Comment 16 2012-12-13 15:42:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.