Bug 84849

Summary: Web Inspector: use composite node provider for diff nodes in heap profiler
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Description Yury Semikhatsky 2012-04-25 05:17:32 PDT
Instead of overriding HeapSnapshotGridNode.prototype.populateChildren in HeapSnapshotDiffNode we should use a composite nodes provider which will populate first added nodes and after that deleted ones. This step is necessary for adding "reveal element in heap profile" action.
Comment 1 Yury Semikhatsky 2012-04-25 05:24:39 PDT
Created attachment 138788 [details]
Patch
Comment 2 Pavel Feldman 2012-04-25 05:26:51 PDT
Comment on attachment 138788 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711
> +    serializeNextItems: function(count, callback)

serializeSubsequentItems.

> Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713
> +        function didReceiveAllItems(items) {

{ on the next line.
Comment 3 Yury Semikhatsky 2012-04-25 05:29:40 PDT
(In reply to comment #2)
> (From update of attachment 138788 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=138788&action=review
> 
> > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:711
> > +    serializeNextItems: function(count, callback)
> 
> serializeSubsequentItems.
> 
Done.

> > Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js:713
> > +        function didReceiveAllItems(items) {
> 
> { on the next line.
Done.
Comment 4 Yury Semikhatsky 2012-04-25 05:31:20 PDT
Committed r115189: <http://trac.webkit.org/changeset/115189>