Summary: | [EFL] Enable VIDEO_TRACK feature | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2012-04-25 02:05:07 PDT
Created attachment 138776 [details]
Patch
Created attachment 138777 [details]
Patch
Rebase on master so that it applies cleanly.
Created attachment 138784 [details]
Patch
Update patch to fix compilation when VIDEO_TRACK is disabled.
Comment on attachment 138784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138784&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:724 > + priv->settings.shouldDisplaySubtitles = priv->pageSettings->shouldDisplaySubtitles(); I think it is better to add this settings by alphabetic sorting. So, is it better to move below 729 line. > Source/WebKit/efl/ewk/ewk_view.cpp:4084 > + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE); Use standard boolean type instead of EINA_FALSE. > Source/WebKit/efl/ewk/ewk_view.cpp:4085 > + EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE); ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:4108 > + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE); ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:4109 > + EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE); ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:4132 > + EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE); ditto. > Source/WebKit/efl/ewk/ewk_view.cpp:4133 > + EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE); ditto. > Source/WebKit/efl/ewk/ewk_view.h:2460 > +EAPI void ewk_view_setting_should_display_subtitles_set(const Evas_Object *o, Eina_Bool enable); We don't use const keyword in _set APIs. > Source/WebKit/efl/ewk/ewk_view.h:2481 > +EAPI void ewk_view_setting_should_display_captions_set(const Evas_Object *o, Eina_Bool enable); ditto. > Source/WebKit/efl/ewk/ewk_view.h:2502 > +EAPI void ewk_view_setting_should_display_text_descriptions_set(const Evas_Object *o, Eina_Bool enable); ditto. > Tools/ChangeLog:10 > + * Scripts/build-webkit: Missing description. Created attachment 138938 [details]
Patch
Patch taking feedback into consideration.
Created attachment 138943 [details]
Patch
Minor changelog fix.
Comment on attachment 138943 [details]
Patch
Looks fine.
Comment on attachment 138943 [details] Patch Rejecting attachment 138943 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12523914 Created attachment 139018 [details]
Proposed patch
Fix patch for landing.
Comment on attachment 139018 [details] Proposed patch Clearing flags on attachment: 139018 Committed r115341: <http://trac.webkit.org/changeset/115341> All reviewed patches have been landed. Closing bug. |