Bug 84829

Summary: Failed to render again in offline mode
Product: WebKit Reporter: Xingnan Wang <xingnan.wang>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: crogers, eric.carlson, feature-media-reviews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xingnan Wang
Reported 2012-04-25 00:22:39 PDT
startRendering() will fail to run when called again. The background is that, I wrote two test cases in offline mode(they shared the same audio context), the one after another finished one failed to run startRendering(). OfflineAudioDestinationNode should reset the flag of m_startedRendering after finishing rendering.
Attachments
Patch (1.37 KB, patch)
2012-04-25 00:24 PDT, Xingnan Wang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xingnan Wang
Comment 1 2012-04-25 00:24:22 PDT
Created attachment 138748 [details] Patch
Chris Rogers
Comment 2 2012-04-25 11:44:14 PDT
Hi Xingnan, it's not intended for an OfflineAudioContext to be able to start rendering more than once. It goes through distinct stages during its life, finally calling back the JS completion function. You can always create a 2nd or 3rd OfflineAudioContext if you need to do more work, but the original one can't be re-used. The OfflineAudioContext is not yet in the spec, but I will add it there soon, describing this.
Anders Carlsson
Comment 3 2014-02-05 10:53:07 PST
Comment on attachment 138748 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.