Bug 84792

Summary: [EFL][DRT] Clear added user style sheets before a new testcase execution.
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84718    
Bug Blocks:    
Attachments:
Description Flags
Clear added user style sheets before a new testcase execution
none
Clear added user style sheets before a new testcase execution
gustavo: review+, webkit.review.bot: commit-queue-
to be landed. none

Mikhail Pozdnyakov
Reported 2012-04-24 15:48:22 PDT
The added user style sheets from the previous testcases are not cleared for the next one => have flaky results. For example in bug84718 this issue causes flakiness of userscripts/user-style-top-frame-only.html.
Attachments
Clear added user style sheets before a new testcase execution (5.38 KB, patch)
2012-04-24 16:29 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Clear added user style sheets before a new testcase execution (5.38 KB, patch)
2012-04-25 01:39 PDT, Mikhail Pozdnyakov 		gustavo: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
to be landed. (5.62 KB, patch)
2012-05-10 00:55 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-04-24 16:29:08 PDT
Created attachment 138681 [details] Clear added user style sheets before a new testcase execution The patch is unskipping userscripts/user-script-top-frame-only.html so it may be applied after the fix for bug84718 is in place.
Gyuyoung Kim
Comment 2 2012-04-24 19:46:01 PDT
Comment on attachment 138681 [details] Clear added user style sheets before a new testcase execution View in context: https://bugs.webkit.org/attachment.cgi?id=138681&action=review > LayoutTests/ChangeLog:6 > + Unskip userscripts/user-style-top-frame-only.html Generally, patch description is placed below "Reviewed by NOBODY (OOPS!)."
Mikhail Pozdnyakov
Comment 3 2012-04-25 01:39:33 PDT
Created attachment 138759 [details] Clear added user style sheets before a new testcase execution
Mikhail Pozdnyakov
Comment 4 2012-04-25 01:41:51 PDT
(In reply to comment #2) > (From update of attachment 138681 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138681&action=review > > > LayoutTests/ChangeLog:6 > > + Unskip userscripts/user-style-top-frame-only.html > > Generally, patch description is placed below "Reviewed by NOBODY (OOPS!)." Thanks for review! Changelog is fixed here: https://bugs.webkit.org/attachment.cgi?id=138759
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-04-25 07:37:33 PDT
Comment on attachment 138759 [details] Clear added user style sheets before a new testcase execution Looks good, thanks.
Gustavo Noronha (kov)
Comment 6 2012-05-09 08:22:56 PDT
Comment on attachment 138759 [details] Clear added user style sheets before a new testcase execution OK, looks right to me.
WebKit Review Bot
Comment 7 2012-05-09 08:28:35 PDT
Comment on attachment 138759 [details] Clear added user style sheets before a new testcase execution Rejecting attachment 138759 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: jects to file Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp Hunk #1 FAILED at 213. 1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12656672
Gyuyoung Kim
Comment 8 2012-05-09 22:02:14 PDT
Needs to rebase.
Mikhail Pozdnyakov
Comment 9 2012-05-10 00:55:42 PDT
Created attachment 141103 [details] to be landed.
WebKit Review Bot
Comment 10 2012-05-10 03:55:17 PDT
Comment on attachment 141103 [details] to be landed. Clearing flags on attachment: 141103 Committed r116625: <http://trac.webkit.org/changeset/116625>
WebKit Review Bot
Comment 11 2012-05-10 03:55:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.