Bug 84782

Summary: Improve code for embedding flakiness dashboard as an iframe
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dpranke, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dpranke: review+

Ojan Vafai
Reported 2012-04-24 14:34:40 PDT
Improve code for embedding flakiness dashboard as an iframe
Attachments
Patch (7.57 KB, patch)
2012-04-24 14:37 PDT, Ojan Vafai 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-04-24 14:37:23 PDT
Created attachment 138649 [details] Patch
Dirk Pranke
Comment 2 2012-04-24 15:18:53 PDT
Comment on attachment 138649 [details] Patch looks reasonable, but who embeds the flakiness dashboard (i.e., why do we want this?). Also, what's a qunit?
Ojan Vafai
Comment 3 2012-04-24 15:44:25 PDT
(In reply to comment #2) > (From update of attachment 138649 [details]) > looks reasonable, but who embeds the flakiness dashboard (i.e., why do we want this?). Also, what's a qunit? I have a patch for garden-o-matic to embed it as an iframe. This is so we can see the flakiness details for a test we're viewing. qunit is the unittesting frameworks that garden-o-matic uses.
Ojan Vafai
Comment 4 2012-04-24 16:43:27 PDT
Committed r115133: <http://trac.webkit.org/changeset/115133>
Note You need to log in before you can comment on or make changes to this bug.