Bug 84749

Summary: [Coverity] Uninitialized fields in RenderSVGShape constructors
Product: WebKit Reporter: Florin Malita <fmalita>
Component: SVGAssignee: Florin Malita <fmalita>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zimmermann
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Florin Malita 2012-04-24 12:22:50 PDT
RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node):
  * m_strokeContainsFallBack

RenderSVGShape::RenderSVGShape(SVGStyledTransformableElement* node, Path* path, bool isFillFallback):
  * m_needsTransformUpdate
  * m_needsShapeUpdate
  * m_strokeContainsFallBack
  * m_needsBoundariesUpdate

Looks like neither m_strokeContainsFallBack nor the second constructor is being used, so we can simply get rid of them.
Comment 1 Florin Malita 2012-04-24 12:40:26 PDT
Created attachment 138622 [details]
Patch
Comment 2 Darin Adler 2012-04-24 12:42:05 PDT
Comment on attachment 138622 [details]
Patch

Looks fine. Great to remove unused code!
Comment 3 WebKit Review Bot 2012-04-25 06:44:32 PDT
Comment on attachment 138622 [details]
Patch

Clearing flags on attachment: 138622

Committed r115196: <http://trac.webkit.org/changeset/115196>
Comment 4 WebKit Review Bot 2012-04-25 06:44:37 PDT
All reviewed patches have been landed.  Closing bug.