Bug 84709

Summary:

[EFL][DRT] Reset DRT settings to their default values after a testcase was executed.

Product:

WebKit

Reporter:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Component:

WebKit EFL

Assignee:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

d-r, eric, gustavo, gyuyoung.kim, lucas.de.marchi, mrobinson, pnormand, rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
reset some missed DRT settings	none
reset some missed DRT settings	none

Mikhail Pozdnyakov

Reported 2012-04-24 05:11:52 PDT

Not all the settings affected by layout testcases are reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues(). ones corresponding to the setters below are missed: ewk_view_setting_user_stylesheet_set ewk_view_setting_enable_xss_auditor_set ewk_view_setting_enable_developer_extras_set ewk_view_setting_minimum_timer_interval_set DumpRenderTreeSupportEfl::setSmartInsertDeleteEnabled DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled DumpRenderTreeSupportEfl::setDefersLoading DumpRenderTreeSupportEfl::setEditingBehavior It may cause flakiness of the test results.

Attachments
reset some missed DRT settings (2.95 KB, patch) 2012-04-24 05:26 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
reset some missed DRT settings (3.12 KB, patch) 2012-04-24 05:46 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mikhail Pozdnyakov

Comment 1 2012-04-24 05:26:36 PDT

Created attachment 138541 [details] reset some missed DRT settings

Dominik Röttsches (drott)

Comment 2 2012-04-24 05:37:11 PDT

Comment on attachment 138541 [details] reset some missed DRT settings View in context: https://bugs.webkit.org/attachment.cgi?id=138541&action=review Otherwise LGTM. > Tools/ChangeLog:7 > + I think it makes sense to put the explanation from the bug report here, e.g.: "Not all the settings that can be changed by layout testcases through a JS API were reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues()."

Mikhail Pozdnyakov

Comment 3 2012-04-24 05:46:01 PDT

Created attachment 138544 [details] reset some missed DRT settings

Raphael Kubo da Costa (:rakuco)

Comment 4 2012-04-24 16:00:57 PDT

Comment on attachment 138544 [details] reset some missed DRT settings Makes sense.

Gyuyoung Kim

Comment 5 2012-04-24 19:54:34 PDT

Comment on attachment 138544 [details] reset some missed DRT settings Looks fine.

Eric Seidel (no email)

Comment 6 2012-04-25 00:31:07 PDT

Comment on attachment 138544 [details] reset some missed DRT settings OK.

WebKit Review Bot

Comment 7 2012-04-25 00:38:35 PDT

Comment on attachment 138544 [details] reset some missed DRT settings Clearing flags on attachment: 138544 Committed r115173: <http://trac.webkit.org/changeset/115173>

WebKit Review Bot

Comment 8 2012-04-25 00:38:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.