Summary: | Implement the field cache of ObjcClass in WebKit types | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
Component: | WebCore Misc. | Assignee: | Benjamin Poulain <benjamin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ggaren, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Benjamin Poulain
2012-04-23 19:11:20 PDT
Created attachment 138487 [details]
Patch
The main gain is from not allocating any memory in that case. Not having to call a function is a bonus :) I have not modified ObjcClass::methodsNamed() due to a bug I will fix separately. Comment on attachment 138487 [details] Patch Attachment 138487 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12523103 (In reply to comment #3) > (From update of attachment 138487 [details]) > Attachment 138487 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/12523103 Unrelated. Something is up with the bot. Comment on attachment 138487 [details]
Patch
What's good for the field must be good for the method!
> What's good for the field must be good for the method! Yep. I did not do the method cache right away because of https://bugs.webkit.org/show_bug.cgi?id=84668 Created attachment 138502 [details]
Patch for landing
Comment on attachment 138502 [details] Patch for landing Clearing flags on attachment: 138502 Committed r115007: <http://trac.webkit.org/changeset/115007> All reviewed patches have been landed. Closing bug. |