Bug 84667

Summary:

Implement the field cache of ObjcClass in WebKit types

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

WebCore Misc.

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Benjamin Poulain

Reported 2012-04-23 19:11:20 PDT

When manipulating bridged object, we spend a lot of time in ObjcClass::fieldNamed().

Attachments
Patch (5.89 KB, patch) 2012-04-23 19:18 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch for landing (5.87 KB, patch) 2012-04-24 00:00 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2012-04-23 19:18:47 PDT

Created attachment 138487 [details] Patch

Benjamin Poulain

Comment 2 2012-04-23 19:20:08 PDT

The main gain is from not allocating any memory in that case. Not having to call a function is a bonus :) I have not modified ObjcClass::methodsNamed() due to a bug I will fix separately.

Build Bot

Comment 3 2012-04-23 19:42:32 PDT

Comment on attachment 138487 [details] Patch Attachment 138487 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12523103

Benjamin Poulain

Comment 4 2012-04-23 19:45:39 PDT

(In reply to comment #3) > (From update of attachment 138487 [details]) > Attachment 138487 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/12523103 Unrelated. Something is up with the bot.

Geoffrey Garen

Comment 5 2012-04-23 22:49:29 PDT

Comment on attachment 138487 [details] Patch What's good for the field must be good for the method!

Benjamin Poulain

Comment 6 2012-04-23 23:51:59 PDT

> What's good for the field must be good for the method! Yep. I did not do the method cache right away because of https://bugs.webkit.org/show_bug.cgi?id=84668

Benjamin Poulain

Comment 7 2012-04-24 00:00:20 PDT

Created attachment 138502 [details] Patch for landing

WebKit Review Bot

Comment 8 2012-04-24 00:48:41 PDT

Comment on attachment 138502 [details] Patch for landing Clearing flags on attachment: 138502 Committed r115007: <http://trac.webkit.org/changeset/115007>

WebKit Review Bot

Comment 9 2012-04-24 00:48:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.