Bug 84637

Summary: [V8][Refactoring] throwTypeError() should take one string argument that explains what the type error is
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-04-23 14:46:41 PDT
Current behavior: - throwError("foo", V8Proxy::TypeError) is equivalent to throwError("foo") - throwTypeError() is equivalent to throwError("Type Error") We want to unify them as follows: (1) throwTypeError() should take one string argument which explains what the type error is. Just "Type Error" is not descriptive. (2) Replace all throwError("foo") with throwTypeError("foo"). (3) Replace all throwError("foo", V8Proxy::TypeError) with throwTypeError("foo"). Consequently, only throwTypeError("...") will remain in the binding code. In this bug, we fix (1).
Attachments
Patch (14.78 KB, patch)
2012-04-23 15:47 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-04-23 15:47:19 PDT
Created attachment 138443 [details] Patch
Kentaro Hara
Comment 2 2012-04-24 10:05:26 PDT
We need to fix JSC side too to align the behavior, and thus the fix would be controversial. Let me mark as WONTFIX for now.
Note You need to log in before you can comment on or make changes to this bug.