Bug 84634

Summary: [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
Product: WebKit Reporter: Raphael Kubo da Costa (:rakuco) <rakuco>
Component: WebKit EFLAssignee: Raphael Kubo da Costa (:rakuco) <rakuco>
Status: RESOLVED FIXED    
Severity: Normal CC: g.czajkowski, gyuyoung.kim, lucas.de.marchi, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Convert another method in LTC
none
Patch for landing none

Raphael Kubo da Costa (:rakuco)
Reported 2012-04-23 14:33:10 PDT
[EFL] Pass a WTF::String directly from DRT to ewebkit when possible
Attachments
Patch (8.23 KB, patch)
2012-04-23 14:34 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Convert another method in LTC (8.84 KB, patch)
2012-04-25 15:26 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.18 KB, patch)
2012-05-08 17:41 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-04-23 14:34:48 PDT
Created attachment 138427 [details] Patch
Grzegorz Czajkowski
Comment 2 2012-04-23 23:31:21 PDT
Makes sense, LGTM.
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-04-25 15:26:01 PDT
Created attachment 138883 [details] Convert another method in LTC
WebKit Review Bot
Comment 4 2012-05-08 17:08:52 PDT
Comment on attachment 138883 [details] Convert another method in LTC Rejecting attachment 138883 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: RenderTreeSupportEfl.h.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp Hunk #1 succeeded at 184 (offset -5 lines). Hunk #2 succeeded at 270 (offset 3 lines). Hunk #3 succeeded at 515 (offset 6 lines). Hunk #4 succeeded at 701 (offset 37 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12601016
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-05-08 17:41:20 PDT
Created attachment 140830 [details] Patch for landing
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-05-08 17:42:26 PDT
Committed r116470: <http://trac.webkit.org/changeset/116470>
Note You need to log in before you can comment on or make changes to this bug.