| Summary: | [EFL] Pass a WTF::String directly from DRT to ewebkit when possible | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||
| Component: | WebKit EFL | Assignee: | Raphael Kubo da Costa (:rakuco) <rakuco> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | g.czajkowski, gyuyoung.kim, lucas.de.marchi, tonikitoo, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Raphael Kubo da Costa (:rakuco)
2012-04-23 14:33:10 PDT
Created attachment 138427 [details]
Patch
Makes sense, LGTM. Created attachment 138883 [details]
Convert another method in LTC
Comment on attachment 138883 [details] Convert another method in LTC Rejecting attachment 138883 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: RenderTreeSupportEfl.h.rej patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp Hunk #1 succeeded at 184 (offset -5 lines). Hunk #2 succeeded at 270 (offset 3 lines). Hunk #3 succeeded at 515 (offset 6 lines). Hunk #4 succeeded at 701 (offset 37 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Gustavo No..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12601016 Created attachment 140830 [details]
Patch for landing
Committed r116470: <http://trac.webkit.org/changeset/116470> |