Bug 84594

Summary: [Qt] Incomplete interaction-engine reset
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit2Assignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2012-04-23 06:50:32 PDT
The scaling stack is not reset in QtViewportInteractionEngine::reset(), this leads to odd zooming behaviour if first using the tap-to-zoom gesture and then resizing the viewport in the minibrowser.
Attachments
Patch (1.56 KB, patch)
2012-04-23 06:52 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.54 KB, patch)
2012-04-23 07:43 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2012-04-23 06:52:11 PDT
Created attachment 138339 [details] Patch
Alexis Menard (darktears)
Comment 2 2012-04-23 06:58:46 PDT
Comment on attachment 138339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138339&action=review Could you look if m_pinchStartScale needs also to be reset? I mean since you are fixing the reset method make sure all the content that needs to be cleared is actually reset. > Source/WebKit2/ChangeLog:3 > + [Qt] Scaling stack not reset on reset. nitpick : Scaling stack not cleared on reset.
Allan Sandfeld Jensen
Comment 3 2012-04-23 07:43:11 PDT
Created attachment 138342 [details] Patch
WebKit Review Bot
Comment 4 2012-04-24 01:53:03 PDT
Comment on attachment 138342 [details] Patch Clearing flags on attachment: 138342 Committed r115012: <http://trac.webkit.org/changeset/115012>
WebKit Review Bot
Comment 5 2012-04-24 01:53:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.