Bug 84593

Summary: [EFL][DRT] WebKitAnimation API compile-time disabled
Product: WebKit Reporter: Dominik Röttsches (drott) <d-r>
Component: WebKit EFLAssignee: Dominik Röttsches (drott) <d-r>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gyuyoung.kim, gyuyoung.kim, hausmann, joone, kenneth, lucas.de.marchi, morrita, rakuco, ryuan.choi, sw0524.lee, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dominik Röttsches (drott)
Reported 2012-04-23 06:35:50 PDT
animations/animation-api-1.html fails since the API object is not present.
Attachments
Patch (4.84 KB, patch)
2012-08-01 22:10 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1 2012-04-23 07:45:05 PDT
webkitGetAnimations() is conditional on ENABLE_ANIMATION_API and currently disabled.
Joone Hur
Comment 2 2012-07-31 23:51:30 PDT
The test case was added by this commit: https://trac.webkit.org/changeset/80846
Joone Hur
Comment 3 2012-08-01 22:10:35 PDT
Created attachment 155973 [details] Patch
Joone Hur
Comment 4 2012-08-01 22:17:35 PDT
Enabling ENABLE_ANIMATION_API flag makes animations/animation-api-1.html pass on WK1 and WK2 test.
Ryuan Choi
Comment 5 2012-08-01 22:23:26 PDT
LGTM.
Laszlo Gombos
Comment 6 2012-08-02 16:10:47 PDT
Comment on attachment 155973 [details] Patch r=me. Is this the only test passing from the Skipped list by enabling this feature flag ?
Joone Hur
Comment 7 2012-08-02 23:55:15 PDT
(In reply to comment #6) > (From update of attachment 155973 [details]) > r=me. > > Is this the only test passing from the Skipped list by enabling this feature flag ? Yes, this test case passes by just enabling ENABLE_ANIMATION_API flag. Thanks for r+.
WebKit Review Bot
Comment 8 2012-08-03 00:33:26 PDT
Comment on attachment 155973 [details] Patch Clearing flags on attachment: 155973 Committed r124569: <http://trac.webkit.org/changeset/124569>
WebKit Review Bot
Comment 9 2012-08-03 00:33:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.