| Summary: | [EFL] Documentation update for some ewk functions | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Krzysztof Czech <k.czech> | ||||||||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, tkent, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Krzysztof Czech
2012-04-23 06:07:11 PDT
Created attachment 138330 [details]
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Attachment 138330 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 138334 [details]
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Comment on attachment 138334 [details] Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set. View in context: https://bugs.webkit.org/attachment.cgi?id=138334&action=review > Source/WebKit/efl/ewk/ewk_view.h:2219 > + * @return @c EINA_TRUE if zoom range is changed or not, @c EINA_FALSE on failure This could be rephrased to "EINA_TRUE on success, @c EINA_FALSE on failure" to keep consistency. Created attachment 138503 [details]
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Created attachment 138504 [details]
Update documentation patch
Comment on attachment 138504 [details]
Update documentation patch
Looks good, thanks.
Could you review it. Comment on attachment 138504 [details]
Update documentation patch
rs=me.
Comment on attachment 138504 [details] Update documentation patch Rejecting attachment 138504 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12646281 Created attachment 140696 [details]
Add missing reviewer line
Comment on attachment 140696 [details] Add missing reviewer line Clearing flags on attachment: 140696 Committed r116413: <http://trac.webkit.org/changeset/116413> All reviewed patches have been landed. Closing bug. |