Bug 84588 - [EFL] Documentation update for some ewk functions
Summary: [EFL] Documentation update for some ewk functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-23 06:07 PDT by Krzysztof Czech
Modified: 2012-05-08 06:31 PDT (History)
5 users (show)

See Also:

Attachments
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set. (2.11 KB, patch)
2012-04-23 06:15 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set. (2.11 KB, patch)
2012-04-23 06:27 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set. (2.09 KB, patch)
2012-04-24 00:01 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Update documentation patch (2.09 KB, patch)
2012-04-24 00:02 PDT, Krzysztof Czech 		eric: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Add missing reviewer line (2.12 KB, patch)
2012-05-08 02:12 PDT, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2012-04-23 06:07:11 PDT 
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Comment 1 Krzysztof Czech 2012-04-23 06:15:11 PDT 
Created attachment 138330 [details]
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.

Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Comment 2 WebKit Review Bot 2012-04-23 06:18:28 PDT 
Attachment 138330 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/efl/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Krzysztof Czech 2012-04-23 06:27:10 PDT 
Created attachment 138334 [details]
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-04-23 07:15:36 PDT 
Comment on attachment 138334 [details]
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.

View in context: https://bugs.webkit.org/attachment.cgi?id=138334&action=review

> Source/WebKit/efl/ewk/ewk_view.h:2219
> + * @return @c EINA_TRUE if zoom range is changed or not, @c EINA_FALSE on failure

This could be rephrased to "EINA_TRUE on success, @c EINA_FALSE on failure" to keep consistency.
Comment 5 Krzysztof Czech 2012-04-24 00:01:03 PDT 
Created attachment 138503 [details]
Update documentation of ewk_frame_contents_alternate_set and ewk_view_zoom_range_set.
Comment 6 Krzysztof Czech 2012-04-24 00:02:10 PDT 
Created attachment 138504 [details]
Update documentation patch
Comment 7 Raphael Kubo da Costa (:rakuco) 2012-04-24 13:43:50 PDT 
Comment on attachment 138504 [details]
Update documentation patch

Looks good, thanks.
Comment 8 Krzysztof Czech 2012-04-25 06:47:31 PDT 
Could you review it.
Comment 9 Eric Seidel (no email) 2012-05-08 01:06:18 PDT 
Comment on attachment 138504 [details]
Update documentation patch

rs=me.
Comment 10 WebKit Review Bot 2012-05-08 01:08:30 PDT 
Comment on attachment 138504 [details]
Update documentation patch

Rejecting attachment 138504 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/12646281
Comment 11 Krzysztof Czech 2012-05-08 02:12:49 PDT 
Created attachment 140696 [details]
Add missing reviewer line
Comment 12 WebKit Review Bot 2012-05-08 06:31:48 PDT 
Comment on attachment 140696 [details]
Add missing reviewer line

Clearing flags on attachment: 140696

Committed r116413: <http://trac.webkit.org/changeset/116413>
Comment 13 WebKit Review Bot 2012-05-08 06:31:53 PDT 
All reviewed patches have been landed.  Closing bug.