Bug 84526

Summary:

webkit-gtk-1.8.0 fails to build with --disable-video in DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp

Product:

WebKit

Reporter:

Alexandre Rostovtsev <tetromino>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, berto, gnome, haraken, japhet, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Simple patch for CodeGeneratorGObject.pm	none

Description Alexandre Rostovtsev 2012-04-21 02:29:29 PDT

(as reported downstream at https://bugs.gentoo.org/show_bug.cgi?id=412221)
If configured with --disable-video, webkit-gtk-1.8.0 build fails with:

DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function ‘void webkit_dom_html_media_element_set_property(GObject*, guint, const GValue*, GParamSpec*)’:
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:5: error: ‘HTMLMediaElement’ is not a member of ‘WebCore’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:32: error: ‘coreSelf’ was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:149:43: error: ‘core’ is not a member of ‘WebKit’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp: In function ‘void webkit_dom_html_media_element_get_property(GObject*, guint, GValue*, GParamSpec*)’:
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:5: error: ‘HTMLMediaElement’ is not a member of ‘WebCore’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:32: error: ‘coreSelf’ was not declared in this scope
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:234:43: error: ‘core’ is not a member of ‘WebKit’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:16: error: ‘MediaError’ is not a member of ‘WebCore’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:16: error: ‘MediaError’ is not a member of ‘WebCore’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:35: error: template argument 1 is invalid
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:238:41: error: invalid type in declaration before ‘=’ token
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:239:51: error: request for member ‘get’ in ‘ptr’, which is of non-class type ‘int’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:265:56: error: no matching function for call to ‘kit(WebCore::TimeRanges*)’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:265:56: note: candidates are:
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: WebKitDOMNode* WebKit::kit(WebCore::Node*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Node*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: WebKitDOMElement* WebKit::kit(WebCore::Element*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Element*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: WebKitDOMEvent* WebKit::kit(WebCore::Event*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Event*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: WebKitDOMEventTarget* WebKit::kit(WebCore::EventTarget*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::EventTarget*’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:316:56: error: no matching function for call to ‘kit(WebCore::TimeRanges*)’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:316:56: note: candidates are:
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: WebKitDOMNode* WebKit::kit(WebCore::Node*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Node*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: WebKitDOMElement* WebKit::kit(WebCore::Element*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Element*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: WebKitDOMEvent* WebKit::kit(WebCore::Event*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Event*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: WebKitDOMEventTarget* WebKit::kit(WebCore::EventTarget*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::EventTarget*’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:322:56: error: no matching function for call to ‘kit(WebCore::TimeRanges*)’
DerivedSources/webkit/WebKitDOMHTMLMediaElement.cpp:322:56: note: candidates are:
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note: WebKitDOMNode* WebKit::kit(WebCore::Node*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:38:16: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Node*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note: WebKitDOMElement* WebKit::kit(WebCore::Element*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:39:19: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Element*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note: WebKitDOMEvent* WebKit::kit(WebCore::Event*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:40:17: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::Event*’
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note: WebKitDOMEventTarget* WebKit::kit(WebCore::EventTarget*)
./Source/WebCore/bindings/gobject/WebKitDOMBinding.h:41:23: note:   no known conversion for argument 1 from ‘WebCore::TimeRanges*’ to ‘WebCore::EventTarget*’
make: *** [DerivedSources/webkit/libwebkitgtk_3_0_la-WebKitDOMHTMLMediaElement.lo] Error 1

Comment 1 Mikhail Khokhlov 2012-04-28 03:31:21 PDT

Created attachment 139350 [details]
Simple patch for CodeGeneratorGObject.pm

Comment 2 Alexandre Rostovtsev 2012-05-02 23:52:08 PDT

(In reply to comment #1)
> Created an attachment (id=139350) [details]
> Simple patch for CodeGeneratorGObject.pm

Thanks, that fixes the build failure.

Comment 3 Alberto Garcia 2013-09-12 14:36:08 PDT

There's a problem now since disabling VIDEO also requires to disable VIDEO_TRACK (I filed bug 121259 about that problem).

But otherwise the issue described here is no longer present, so I'm closing this bug.