Bug 84471

Summary: [BlackBerry] Expose WebViewportArguments to WebPageClient
Product: WebKit Reporter: Mike Lattanzio <mlattanzio>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kpiascik, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Mike Lattanzio
Reported 2012-04-20 11:15:34 PDT
Give our client implementation the ability to provide some fallback ViewportArguments. Now clients can essentially set a meta viewport to increase mobile readability without touching the HTML content they request to be loaded.
Attachments
Patch (16.85 KB, patch)
2012-04-20 11:35 PDT, Mike Lattanzio 		no flags
DetailsFormatted DiffDiff
Patch (14.41 KB, patch)
2012-04-20 11:37 PDT, Mike Lattanzio 		no flags
DetailsFormatted DiffDiff
Patch (15.13 KB, patch)
2012-04-20 12:22 PDT, Mike Lattanzio 		no flags
DetailsFormatted DiffDiff
Patch (15.31 KB, patch)
2012-04-20 12:56 PDT, Mike Lattanzio 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mike Lattanzio
Comment 1 2012-04-20 11:35:06 PDT
Created attachment 138129 [details] Patch
Mike Lattanzio
Comment 2 2012-04-20 11:37:33 PDT
Created attachment 138130 [details] Patch
Mike Lattanzio
Comment 3 2012-04-20 12:22:58 PDT
Created attachment 138144 [details] Patch
Konrad Piascik
Comment 4 2012-04-20 12:36:12 PDT
you still didn't explain in your patch why you need currentViewportArguments and are not overriding m_viewportArguments, I think this is the important thing to note....also do you have any tests?
Mike Lattanzio
Comment 5 2012-04-20 12:56:43 PDT
Created attachment 138148 [details] Patch
Mike Lattanzio
Comment 6 2012-04-20 13:00:12 PDT
(In reply to comment #4) > you still didn't explain in your patch why you need currentViewportArguments and are not overriding m_viewportArguments, I think this is the important thing to note....also do you have any tests? The new patch has more thorough comments. API tests for the WebViewportArguments are in launcher. This patch doesn't affect anything by default so no new tests for webkit.
Konrad Piascik
Comment 7 2012-04-20 13:01:24 PDT
(In reply to comment #6) > (In reply to comment #4) > > you still didn't explain in your patch why you need currentViewportArguments and are not overriding m_viewportArguments, I think this is the important thing to note....also do you have any tests? > > The new patch has more thorough comments. API tests for the WebViewportArguments are in launcher. This patch doesn't affect anything by default so no new tests for webkit. Looks good to me.
Antonio Gomes
Comment 8 2012-04-20 13:20:01 PDT
Comment on attachment 138148 [details] Patch still think d should not be a pointer, but ok.
WebKit Review Bot
Comment 9 2012-04-20 14:20:08 PDT
Comment on attachment 138148 [details] Patch Clearing flags on attachment: 138148 Committed r114779: <http://trac.webkit.org/changeset/114779>
WebKit Review Bot
Comment 10 2012-04-20 14:20:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.