Summary: | [EFL][DRT] SVG Batik test fails to display Chinese characters | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominik Röttsches (drott) <d-r> | ||||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, gyuyoung.kim, lucas.de.marchi, mrobinson, rakuco, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 86227 | ||||||||||||
Attachments: |
|
Description
Dominik Röttsches (drott)
2012-04-20 09:44:52 PDT
This is not in this test only. All the tests that require CJK fonts are failing. The reason is that there are not CJK fonts in webkitgtkfonts package. Adding a font like /usr/share/fonts/wqy-zenhei/wqy-zenhei.ttc (for chinese) fixes this test. It is under GNU GPL v2 (http://en.wikipedia.org/wiki/WenQuanYi). This is not specific to EFL port by the way, the GTK port has exactly the same issue for this test since it is using the same font. mrobinson: Is it possible to add fonts (like wqy-zenhei.ttc) to webkitgtkfonts if we notice some test cases require them? Created attachment 140932 [details]
Patch
Add WenQuanYi fonts to jhbuild.modules and load them in DRT. Rebaseline EFL expectations for svg/batik/text/verticalText.svg now that Chinese characters are properly displayed.
Created attachment 140935 [details]
Patch
Regenerate diff with --binary so that PNG result is included.
Created attachment 140937 [details]
Patch
Fix printed message in case one of the font folders cannot be loaded (Thanks Dominik).
It's probably better to add this font directly to webkitgtk-test-fonts, indeed. Comment on attachment 140937 [details]
Patch
Ok, clearing the flags then.
I made the following pull request to webkitgtk-fonts: https://github.com/mrobinson/webkitgtk-test-fonts/pull/3 Made the following pull request to webkitgtk-fonts instead: https://github.com/mrobinson/webkitgtk-test-fonts/pull/4 Now using the same fonts as chromium-linux. (In reply to comment #9) > Made the following pull request to webkitgtk-fonts instead: > https://github.com/mrobinson/webkitgtk-test-fonts/pull/4 > > Now using the same fonts as chromium-linux. Merged and uploaded a new version of the package: https://github.com/downloads/mrobinson/webkitgtk-test-fonts/webkitgtk-test-fonts-0.0.3.tar.gz Created attachment 141356 [details]
Patch
Update to webkitgtk-fonts v0.0.3 and rebaseline svg/batik/text/verticalText.svg now that EFL's DumpRenderTree is able to display Chinese characters.
Addressing this issue on GTK port at Bug 86198. Looks fine, thanks for working on this. Comment on attachment 141356 [details] Patch Clearing flags on attachment: 141356 Committed r116776: <http://trac.webkit.org/changeset/116776> All reviewed patches have been landed. Closing bug. |