Summary: | [chromium] Don't crash when scrolling empty layer tree | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sami Kyostila <skyostil> | ||||||
Component: | New Bugs | Assignee: | Sami Kyostila <skyostil> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cc-bugs, jamesr, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Sami Kyostila
2012-04-20 08:20:06 PDT
Created attachment 138096 [details]
Patch
Comment on attachment 138096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245 > + if (!m_rootLayerImpl) > + return false; > + false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw. (In reply to comment #2) > (From update of attachment 138096 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=138096&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:245 > > + if (!m_rootLayerImpl) > > + return false; > > + > > false here means something specific (we checkerboarded with an animation). i'd rather as assert in this function, and guard on m_rootLayerImpl in the calling function, like we do with prepareToDraw. Ah, I missed that. New patch coming up. Created attachment 138100 [details]
Patch
Comment on attachment 138100 [details] Patch Clearing flags on attachment: 138100 Committed r114761: <http://trac.webkit.org/changeset/114761> All reviewed patches have been landed. Closing bug. |