Bug 84451

Summary:

[EFL] Hyperlink auditing ewk_view setting

Product:

WebKit

Reporter:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Component:

WebKit EFL

Assignee:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

83007

Attachments:

Description	Flags
Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing	none
Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing	none

Mikhail Pozdnyakov

Reported 2012-04-20 07:52:07 PDT

ewk_view should expose hyperlinkAuditingEnabled setting in order to provide EFL's LayoutTestController overridePreference implementation.

Attachments
Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing (5.45 KB, patch) 2012-04-21 09:09 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing (5.45 KB, patch) 2012-04-25 13:02 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mikhail Pozdnyakov

Comment 1 2012-04-21 09:09:46 PDT

Created attachment 138236 [details] Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing

Raphael Kubo da Costa (:rakuco)

Comment 2 2012-04-21 19:57:36 PDT

Comment on attachment 138236 [details] Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing View in context: https://bugs.webkit.org/attachment.cgi?id=138236&action=review Looks fine. > Source/WebKit/efl/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). Minor nit: the "Reviewed by" line usually goes right after the bug link.

Mikhail Pozdnyakov

Comment 3 2012-04-25 13:02:33 PDT

Created attachment 138862 [details] Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing Fixed changelog.

Antonio Gomes

Comment 4 2012-05-02 07:32:48 PDT

Comment on attachment 138862 [details] Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing Is this only for LayoutTestController purposes? Should not it be better to use DumpRenderTreeSupportEFL instead?

Mikhail Pozdnyakov

Comment 5 2012-05-02 07:36:54 PDT

(In reply to comment #4) > (From update of attachment 138862 [details]) > Is this only for LayoutTestController purposes? Should not it be better to use DumpRenderTreeSupportEFL instead? Think having of such api is also important. From the standard http://www.whatwg.org/specs/web-apps/current-work/#hyperlink-auditing: Based on the user's preferences, UAs may either ignore the ping attribute altogether, or selectively ignore URLs in the list (e.g. ignoring any third-party URLs).

Antonio Gomes

Comment 6 2012-05-02 07:39:05 PDT

Comment on attachment 138862 [details] Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing ok

WebKit Review Bot

Comment 7 2012-05-02 08:16:28 PDT

Comment on attachment 138862 [details] Exporting new ewk_view setting: hyperlinkAuditingEnabled - enbles/disables hyperlink auditing Clearing flags on attachment: 138862 Committed r115834: <http://trac.webkit.org/changeset/115834>

WebKit Review Bot

Comment 8 2012-05-02 08:16:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.