Bug 84447

Summary:

Web Inspector: follow up to r114729: more @return annotations added.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Description Pavel Feldman 2012-04-20 06:52:14 PDT

Patch to follow.

Comment 1 Pavel Feldman 2012-04-20 06:54:20 PDT

Created attachment 138087 [details]
Patch

Comment 2 Yury Semikhatsky 2012-04-20 09:17:44 PDT

Comment on attachment 138087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=138087&action=review

> Source/WebCore/inspector/front-end/Resource.js:54
> +    /** @type {?string} */ this._content;

Type annotation should go above the field and the field should be initialized here.

> Source/WebCore/inspector/front-end/ResourceUtils.js:113
> +    var parsedURL = new WebInspector.ParsedURL(this.toString());

Why do you need to call toString()? Would @this {string} annotation help?

Comment 3 Pavel Feldman 2012-04-20 09:28:23 PDT

Committed r114754: <http://trac.webkit.org/changeset/114754>