Bug 84424

Summary:

REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rniwa, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix the bug	none
Fixed per Mark's comment	none

Mark Rowe (bdash)

Reported 2012-04-19 22:44:16 PDT

I noticed while poking around this evening that the Windows build slaves are no longer including .pdb files in the .zip file that they upload to the master for the test slaves to use. The change in question appears to have been made for the benefit of Chromium bots, so it's unclear why these files are being excluded from non-Chromium builds.

Attachments
Fix the bug (2.02 KB, patch) 2012-04-19 23:38 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Fixed per Mark's comment (2.39 KB, patch) 2012-04-19 23:56 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2012-04-19 22:47:47 PDT

(In reply to comment #0) > I noticed while poking around this evening that the Windows build slaves are no longer including .pdb files in the .zip file that they upload to the master for the test slaves to use. The change in question appears to have been made for the benefit of Chromium bots, so it's unclear why these files are being excluded from non-Chromium builds. Oh, I didn't know that. Let me upload a patch then.

Ryosuke Niwa

Comment 2 2012-04-19 23:38:25 PDT

Created attachment 138050 [details] Fix the bug

Mark Rowe (bdash)

Comment 3 2012-04-19 23:52:34 PDT

Comment on attachment 138050 [details] Fix the bug I'm not sure how I feel about this change. I'm not sure how much sense it makes for the patterns to be shared like this given that there's very little overlap between the patterns used by Windows vs Chromium. The Windows code only wants to exclude *.ilk (that's what it did prior to r112781). Can the callers pass in the array of patterns instead, with the Windows and Chromium sets being defined as module-level variables?

Ryosuke Niwa

Comment 4 2012-04-19 23:53:50 PDT

Sure.

Ryosuke Niwa

Comment 5 2012-04-19 23:56:55 PDT

Created attachment 138052 [details] Fixed per Mark's comment

WebKit Review Bot

Comment 6 2012-04-20 00:42:45 PDT

Comment on attachment 138052 [details] Fixed per Mark's comment Clearing flags on attachment: 138052 Committed r114725: <http://trac.webkit.org/changeset/114725>

WebKit Review Bot

Comment 7 2012-04-20 00:42:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.