Bug 84416

Summary: Inline the JSArray constructor
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: JavaScriptCoreAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Description Benjamin Poulain 2012-04-19 20:12:51 PDT 
Inline the JSArray constructor, it is trivial, all its parents are inline, and it takes time to jump to it.
Comment 1 Benjamin Poulain 2012-04-19 20:44:23 PDT 
Created attachment 138036 [details]
Patch
Comment 2 Build Bot 2012-04-19 21:11:11 PDT 
Comment on attachment 138036 [details]
Patch

Attachment 138036 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12469112
Comment 3 Benjamin Poulain 2012-04-19 23:49:10 PDT 
9>jsc.obj : error LNK2005: "protected: __thiscall JSC::JSArray::JSArray(class JSC::JSGlobalData &,class JSC::Structure *)" (??0JSArray@JSC@@IAE@AAVJSGlobalData@1@PAVStructure@1@@Z) already defined in JavaScriptCore.lib(JavaScriptCore.dll)

This is mysterious. Does Windows systematically generate symbols for inlined functions?
Comment 4 Benjamin Poulain 2012-04-20 11:32:10 PDT 
Created attachment 138126 [details]
Patch
Comment 5 Geoffrey Garen 2012-04-20 15:18:55 PDT 
Comment on attachment 138126 [details]
Patch

r=me
Comment 6 Benjamin Poulain 2012-04-20 15:53:44 PDT 
Committed r114793: <http://trac.webkit.org/changeset/114793>