Bug 84409

Summary: computeNonFastScrollableRegion needs to traverse the entire frame tree
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 84412    
Bug Blocks:    
Attachments:
Description Flags
Patch mitz: review+

Anders Carlsson
Reported 2012-04-19 18:11:20 PDT
computeNonFastScrollableRegion needs to traverse the entire frame tree
Attachments
Patch (4.49 KB, patch)
2012-04-19 18:13 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2012-04-19 18:13:13 PDT
Created attachment 138021 [details] Patch
James Robinson
Comment 2 2012-04-19 18:21:07 PDT
Comment on attachment 138021 [details] Patch Can you write some tests for this using the numberOfScrollable... hook?
Anders Carlsson
Comment 3 2012-04-19 18:22:27 PDT
(In reply to comment #2) > (From update of attachment 138021 [details]) > Can you write some tests for this using the numberOfScrollable... hook? Unfortunately not, the number of scrollable areas will be the same after this fix, it's just the non-fast-scrollable region that will be different. We should really figure out a good way to test this :(
mitz
Comment 4 2012-04-19 18:38:47 PDT
Comment on attachment 138021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=138021&action=review > Source/WebCore/ChangeLog:14 > + (WebCore::ScrollingCoordinator::frameViewLayoutUpdated): Please explain why checking for scrollability is no longer needed in this function.
Anders Carlsson
Comment 5 2012-04-19 18:41:09 PDT
Committed r114711: <http://trac.webkit.org/changeset/114711>
Antonio Gomes
Comment 6 2012-04-19 20:56:45 PDT
It was rolled out, reopening...
Anders Carlsson
Comment 7 2012-04-20 15:38:58 PDT
Committed r114792: <http://trac.webkit.org/changeset/114792>
Note You need to log in before you can comment on or make changes to this bug.